Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.deepin-screenshot: fix FHS hard coded path #59429

Merged
merged 2 commits into from Apr 13, 2019
Merged

deepin.deepin-screenshot: fix FHS hard coded path #59429

merged 2 commits into from Apr 13, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 13, 2019

Motivation for this change

Fix the use of the fixPath bash helper function.

    # Usage:
    #
    #   fixPath <parent dir> <path> <files>
    #
    # replaces occurences of <path> by <parent_dir><path> in <files>
    # removing /usr from the start of <path> if present

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo mentioned this pull request Apr 13, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

I like the debug output you mentioned in #59242 (comment)

@romildo
Copy link
Contributor Author

romildo commented Apr 13, 2019

I like the debug output you mentioned in #59242 (comment)

I will add it back then.

@worldofpeace worldofpeace merged commit bbb7657 into NixOS:master Apr 13, 2019
@worldofpeace
Copy link
Contributor

Sorry about that. Thanks 👍

@romildo romildo deleted the upd.deepin.deepin-screenshot branch April 14, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @worldofpeace @GrahamcOfBorg