New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browsh: 1.4.13 -> 1.5.0 #59430
browsh: 1.4.13 -> 1.5.0 #59430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and it worked
Same, but looking at commits they seem to have changes to go dependencies -- which I guess aren't needed but probably should be used even so :). |
@dtzWill If you look at line 24, there At any rate, when I changed |
as long as the hash in fetchXXX isn't changed and the data is in cache, it won't care about other parameters. So you have to change the version, change one character in the hash so fetchXXX detects the data is not in cache, attempts to fetch it and then errors out with the correct checksum. You can then update the checksum with that one. At least that's how I do it. |
@teto yup, that's exactly what I did, too. |
Because deps.nix isn't part of what goes into the source hash. So always need to manually check and re-generate that manually, at least for now. |
Maybe mention deps.nix near 'src' declaration for future commiters/reviewers. |
@DanielFabian I believe this is all that is outstanding for @teto to merge. |
sorry, I missed this as a PR comment, I'll do it tomorrow |
@GrahamcOfBorg build browsh |
tested locally looked ok. thanks ! |
Motivation for this change
1.4.13 is broken with Firefox 66 due to a breaking change in Firefox. Browsh 1.5.0 has a fix for it. Built and tested locally.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)