Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browsh: 1.4.13 -> 1.5.0 #59430

Merged
merged 1 commit into from May 16, 2019
Merged

browsh: 1.4.13 -> 1.5.0 #59430

merged 1 commit into from May 16, 2019

Conversation

DanielFabian
Copy link
Contributor

Motivation for this change

1.4.13 is broken with Firefox 66 due to a breaking change in Firefox. Browsh 1.5.0 has a fix for it. Built and tested locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it worked

@dtzWill
Copy link
Member

dtzWill commented Apr 17, 2019

Same, but looking at commits they seem to have changes to go dependencies -- which I guess aren't needed but probably should be used even so :).
Pointing dep2nix at this resulted in: ed41108 which probably can be picked/squashed or copied from if you like.

@DanielFabian
Copy link
Contributor Author

@dtzWill If you look at line 24, there version is used. So If I don't change the hash code for it, that's weird. It turns out in the previous update of this file, that wasn't done, even though version was changed... not quite sure why it worked with the previous hash.

At any rate, when I changed version and it's used to fetch from github, changing the hash felt like the right thing to do... Or am I missing something?

@teto
Copy link
Member

teto commented Apr 18, 2019

as long as the hash in fetchXXX isn't changed and the data is in cache, it won't care about other parameters. So you have to change the version, change one character in the hash so fetchXXX detects the data is not in cache, attempts to fetch it and then errors out with the correct checksum. You can then update the checksum with that one. At least that's how I do it.

@DanielFabian
Copy link
Contributor Author

@teto yup, that's exactly what I did, too.

@dtzWill
Copy link
Member

dtzWill commented Apr 21, 2019

Because deps.nix isn't part of what goes into the source hash. So always need to manually check and re-generate that manually, at least for now.

@teto
Copy link
Member

teto commented Apr 22, 2019

Maybe mention deps.nix near 'src' declaration for future commiters/reviewers.

@aanderse
Copy link
Member

Maybe mention deps.nix near 'src' declaration for future commiters/reviewers.

@DanielFabian I believe this is all that is outstanding for @teto to merge.

@DanielFabian
Copy link
Contributor Author

Maybe mention deps.nix near 'src' declaration for future commiters/reviewers.

@DanielFabian I believe this is all that is outstanding for @teto to merge.

sorry, I missed this as a PR comment, I'll do it tomorrow

@teto
Copy link
Member

teto commented May 16, 2019

@GrahamcOfBorg build browsh

@teto teto merged commit a2aab0e into NixOS:master May 16, 2019
@teto
Copy link
Member

teto commented May 16, 2019

tested locally looked ok. thanks !

@DanielFabian DanielFabian deleted the browsh branch May 16, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants