Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: use lua on aarch64 #61588

Merged
merged 1 commit into from May 16, 2019
Merged

neovim: use lua on aarch64 #61588

merged 1 commit into from May 16, 2019

Conversation

gebner
Copy link
Member

@gebner gebner commented May 16, 2019

Motivation for this change

As suggested in neovim/neovim#7879 (comment), use Lua instead of LuaJIT for neovim on aarch64. This fixes the neovim build on aarch64; I've successfully built and tested it on a raspberry pi 3.

The neovim cmake file requires the option -DPREFER_LUA=ON if lua is used instead of luajit. This is set of the pname of the lua package is lua.

cc maintainers @garbas @manveru @rvolosatovs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member Author

gebner commented May 16, 2019

@GrahamcOfBorg build neovim

@gebner gebner merged commit 3eb9c9f into NixOS:master May 16, 2019
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants