Fix tests by correcting detection of build path sep. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This condition should be inverted. Backslash is legal as a separator in Linux (though misguided) but forward slash is not legal as a separator on Windows. |
|
Hmm. It's only forbidden on Windows in some APIs - I regularly use forward slash. Perhaps the better way would be setting a define from CMake if the build system is win32, and completely dodge trying to do it at runtime. |
|
Yeah, that would be nicer. No idea why I went with |
…arator. Before, would guess incorrectly if the CMake source tree was specified via a relative path (since then the path would not start with /). Now, directly asks CMake if building on Windows or something else, and sets a define.
|
ok, updated accordingly. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, would guess incorrectly if the CMake source tree was specified
via a relative path (since then the path would not start with /).
Now, checks for any backslashes, using them as an indicator that
the backslash is the separator.
Without this, I can't get the test suite to run on Linux, and I'm pretty sure I couldn't get it to run on Windows before.