Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r18.09] leptonica: patch multiple CVEs #61551

Merged
merged 1 commit into from May 16, 2019
Merged

[r18.09] leptonica: patch multiple CVEs #61551

merged 1 commit into from May 16, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 15, 2019

Motivation for this change

Cherrypick of #61217 to 18.09. The k2pdfopt patch (#61302) isn't needed because its custom leptonica doesn't mess with the patches in 18.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
leptonica: patch multiple CVEs
c8cd51d 
this should fix CVE-2018-3836, CVE-2018-7186, CVE-2018-7247 & CVE-2018-7440

a fix for CVE-2018-7441 & CVE-2018-7442 is *not* included as its patches
are very wide-ranging

also enable tests to give confidence that I'm not completely butchering
the code

(cherry-picked from commit 0861ad5)
c0bw3b
c0bw3b approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61551 1

11 package were build:
  • fmbt
  • invoice2data
  • jbig2enc
  • k2pdfopt
  • leptonica
  • paperwork
  • python36Packages.paperwork-backend
  • python36Packages.pyocr
  • tesseract
  • tesseract_4
  • vobsub2srt

@c0bw3b c0bw3b merged commit 2296f0f into NixOS:release-18.09 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @c0bw3b @veprbl