Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG/DL: Implement size containment (and display lock) for NG fieldset algo #16858

Merged
merged 2 commits into from Jun 12, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 15, 2019

This patch adds size containment implementation for fieldsets in
LayoutNG.

Tested with LayoutNGFieldset feature flag.

Along with the new tests,
external/wpt/css/css-contain/contain-size-fieldset-001.html and
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html
are also passing.

R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 958975
Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660866}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@Hexcles
Copy link
Member

Hexcles commented May 22, 2019

@foolip foolip force-pushed the chromium-export-cl-1613844 branch from e9edc10 to f332cda Compare June 4, 2019 12:14
…algo

This patch adds size containment implementation for fieldsets in
LayoutNG.

Tested with LayoutNGFieldset feature flag.

Along with the new tests,
external/wpt/css/css-contain/contain-size-fieldset-001.html and
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html
are also passing.

R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 958975
Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660866}
@foolip
Copy link
Member

foolip commented Jun 12, 2019

contain-size-fieldset-001-ref.html is already a colliding ref name and listed in lint.whitelist, so I'll add this there.

See also #17289 which
was discovered when preparing this change.
@foolip foolip force-pushed the chromium-export-cl-1613844 branch from f332cda to e200178 Compare June 12, 2019 11:16
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 677d31b into master Jun 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1613844 branch June 12, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants