Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdb: 8.2.1 -> 8.3 #61545

Merged
merged 1 commit into from May 20, 2019
Merged

gdb: 8.2.1 -> 8.3 #61545

merged 1 commit into from May 20, 2019

Conversation

jhaasdijk
Copy link
Contributor

@jhaasdijk jhaasdijk commented May 15, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
Copy link
Member

@GrahamcOfBorg build gdb

@ofborg ofborg bot requested a review from nbp May 15, 2019 15:31
@jhaasdijk jhaasdijk changed the base branch from master to staging May 15, 2019 15:43
@Synthetica9
Copy link
Member

@GrahamcOfBorg build gdb

@matthewbauer
Copy link
Member

I'm hoping this fixes #51293

@jhaasdijk
Copy link
Contributor Author

jhaasdijk commented May 15, 2019 •
edited

Could someone maybe remove the 10.rebuild- labels? They are no longer applicable since I changed the base branch from NixOs:master to NixOs:staging

@Synthetica9
Copy link
Member

@jhaasdijk They are still relevant, because they also hold true for the staging branch. If there would have been any change, the bot would have changed the labels.

@jhaasdijk
Copy link
Contributor Author

Oh alright. Smart bot 😄

xbreak
xbreak approved these changes May 19, 2019
View reviewed changes
Copy link
Contributor

@xbreak xbreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on CentOS 7.4 without sandbox:

  • Builds Ok
  • Runs Ok (did some quick tests)
  • Some quick tests with gdbgui also works

@edolstra edolstra merged commit 954a342 into NixOS:staging May 20, 2019
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

I'm hoping this fixes #51293

Darwin seems worsened, actually, blocking nixpkgs-unstable channel ATM:

darwin-nat.c:39:10: fatal error: 'bfd/mach-o.h' file not found

@tscholak
Copy link

@vcunat same here

@smaret smaret mentioned this pull request Jun 11, 2019
Closed
@tscholak
Copy link

@vcunat seems to have been sorted out by this commit: 80b51d9
thanks @matthewbauer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Synthetica9 approved these changes

@xbreak xbreak xbreak approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jhaasdijk @Synthetica9 @matthewbauer @vcunat @tscholak @xbreak @edolstra @Janik-Haag