[LayoutNG] makes margins not collapse if size != intrinsic #16823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610303
branch
2 times, most recently
from
d074a90
to
2957641
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610303
branch
from
2957641
to
71cf8e0
Compare
If a block's size is not equal to the intrinsic size, then margins should not collapse. Bug: 769039 Change-Id: I13b343cf2421d8d49953a8f780d32772fd5eceef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610303 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659978}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610303
branch
from
71cf8e0
to
343e3e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a block's size is not equal to the intrinsic size, then margins
should not collapse.
Bug: 769039
Change-Id: I13b343cf2421d8d49953a8f780d32772fd5eceef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610303
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659978}