Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfaketime: refactor using builtins.placeholder #61510

Merged
merged 1 commit into from May 17, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 14, 2019

Motivation for this change

Refactor libfaketime to set environment variables directly. Use builtins.placeholder to set PREFIX.

Things done

Tested using

diff -aru result-orig/ result-new/

The diff is minimal, has to do with output path self-references, as expected.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor May 14, 2019 21:18
@infinisil infinisil merged commit 1170a61 into NixOS:master May 17, 2019
@veprbl veprbl deleted the pr/libfaketime_placeholder branch December 1, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants