Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs: remove llvm_37 #61508

Merged
merged 1 commit into from May 18, 2019
Merged

pkgs: remove llvm_37 #61508

merged 1 commit into from May 18, 2019

Conversation

thoughtpolice
Copy link
Member

These expressions are now unused, and can be removed to lighten the load
on build machines.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Fits CONTRIBUTING.md.

These expressions are now unused, and can be removed to lighten the load
on build machines.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg eval

} // stdenv.lib.optionalAttrs (stdenv.cc.isGNU && stdenv.hostPlatform.isi686) {
stdenv = overrideCC stdenv buildPackages.gcc6;
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A throw wouldn't hurt here either

@globin globin merged commit 31fdac0 into NixOS:master May 18, 2019
@vcunat vcunat mentioned this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants