[UserTimingL3] Remove '?' from PerformanceMeasureOptions in IDL #16824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610938
branch
4 times, most recently
from
7e44aba
to
b54f65d
Compare
According to the spec, there should be no "?" for startTime and endTime in PerformanceMeasureOptions. The property |startTime| and |endTime| should be renamed as |start| and |end|. Bug: 958162 Change-Id: I437ac19f8d8f5dcb61a4ce43fe9bb1e602ed6f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610938 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#660427}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1610938
branch
from
b54f65d
to
2ba1b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, there should be no "?" for startTime and
endTime in PerformanceMeasureOptions.
The property |startTime| and |endTime| should be renamed as |start|
and |end|.
Bug: 958162
Change-Id: I437ac19f8d8f5dcb61a4ce43fe9bb1e602ed6f6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610938
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660427}