Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 9aa6837853ff
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e2bbc6fb469a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 16, 2019

  1. nixos: fix services.foundationdb.traceFormat for older server versions

    This was a testing oversight that came from #61009 -- I forgot to test
    the new traceFormat option with older server versions while I was
    working on FDB 6.1.
    
    Since trace_format is only available in 6.1+, emitting it
    unconditionally caused older versions of the database fail to start,
    reporting an error. We simply gate it behind a version check instead,
    and assert the format is always XML on older versions. This avoids the
    case where the user has an old version, changes traceFormat willingly,
    and then is confused by why it didn't work.
    
    As reported by @timothyklim in the comments on commit
    c55b923. See
    
        c55b923#r33566132
    
    Signed-off-by: Austin Seipp <aseipp@pobox.com>
    thoughtpolice committed May 16, 2019
    Copy the full SHA
    e2bbc6f View commit details
    Browse the repository at this point in the history