@GrahamcOfBorg build luaPackages.luv neovim-unwrapped

seems to be an issue for darwin https://github.com/NixOS/nixpkgs/pull/61561/checks?check_run_id=129210140

Hmm, it appears there are bundled copies of libuv that are used instead of our provided system version-- favoring a statically linked variant but AFAICT it doesn't look for a provided copy by default regardless.

I've pushed a commit that addresses this (and ensures our system copy is what is used), but not especially fond of where that ended up.

Suggestions/thoughts?

weird it didn't appear before, is that a new thing in libuv ? I skipped over this as I thought it was darwin specific but it's for linux as well. I will have a look, check that it's fine with neovim and merge

yeah the README mentions WITH_SHARED_LIBUV. Have you tried via cmakeFlags = [ -D WITH_SHARED_LIBUV ] ? (is there a specific error for " # This is a hacky way to specify -DWITH_SHARED_LIBUV=ON which # should be possible but I'm unable to make work." or it just doens't work xD ? )

@dtzWill I am doing some update on the lua infrastructure: I have fixed all (?) indentation issues in luarocks-nix and added some fixes that allow to generate packages for more luarock packages.
The only blocking item for me to upstream this is the luv update.
I wanted to know if you had tried the things in my previous posts ? otherwise I will merge this.

I don't know if tried cmakeFlags-- I thought I'd have to plumb it via something that put it in the lua options array/table (as others in this file do for other things).

I'll poke at this a bit more right now and report...

And hooray re:touchups on the luarocks-nix! \o/

Hmm can't seem to get the cmake flags through--although I admit that sure seems like an obtainable goal. I think unless you'd like to take a try then this is the best we have for now :).

thanks for looking into it. Since I want to push some stuff behind this, let's merge it :p
Let's revisit during next luv update (wishful thinking at its best :D)