Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nss: 3.42.1 -> 3.44 #61560

Merged
merged 2 commits into from May 17, 2019
Merged

nss: 3.42.1 -> 3.44 #61560

merged 2 commits into from May 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 15, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andir
andir approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍.

I basically did the same change a few minutes ago but then decided to check for prior PRs..

We might need this for the upcoming Firefox release (~Tuesday). So far the latest Firefox beta doesn't require it but according to the NSS Release page NSS >=3.43 might be required.

The amount of rebuilds isn't that bad and we might have to pick that for master depending on the security issues the next firefox update fixes / reveals 😞

@andir andir merged commit c3c0d56 into NixOS:staging May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @andir