Implement CSS color-scheme property. #16839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1601255
branch
2 times, most recently
from
3ba66ac
to
07d22e1
Compare
Implemented behind a flag. The implementation currently doesn't apply the computed color-scheme to any rendering. Spec: https://drafts.csswg.org/css-color-adjust-1/#color-scheme-prop Intent to implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/xXVJlqlDL_k/discussion Bug: 939811 Change-Id: Ieec8eb247155c02f0df56a9c637a8e1486c0b404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601255 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#662146}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1601255
branch
from
07d22e1
to
743ac6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented behind a flag.
The implementation currently doesn't apply the computed color-scheme to
any rendering.
Spec:
https://drafts.csswg.org/css-color-adjust-1/#color-scheme-prop
Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/xXVJlqlDL_k/discussion
Bug: 939811
Change-Id: Ieec8eb247155c02f0df56a9c637a8e1486c0b404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601255
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662146}