Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winstone: drop package and service #61512

Merged
merged 1 commit into from May 17, 2019
Merged

winstone: drop package and service #61512

merged 1 commit into from May 17, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 14, 2019 •
edited

Motivation for this change

Close #56294
Upstream package is unmaintained for years
and nixpkgs provides alternatives

cc @rickynils @pSub @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b requested a review from infinisil as a code owner May 14, 2019 20:31
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 14, 2019
@infinisil
Copy link
Member

Can you add at least a mkRemovedOption for .enable and replace the attributes with throw "This is unmaintained" or so? I'm not a fan of removing things without a trace.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 15, 2019

Yes ok.
I will rework this later today.

@c0bw3b
winstone: drop package and service
582fd54 
Close NixOS#56294
Upstream package is unmaintained for years
and nixpkgs provides alternatives
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 15, 2019

@infinisil > I added some messages for a smoother deprecation of both pkg and module

@infinisil infinisil merged commit 85c0a4d into NixOS:master May 17, 2019
Picking up garbage automation moved this from To do to Done May 17, 2019
@c0bw3b c0bw3b deleted the pkg/winstone branch May 17, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove winstone package and module?
2 participants
@c0bw3b @infinisil