-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vokoscreen-beta: init at 2.5.8 #61053
Conversation
The stable version is ancient, I would just update the existing package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nitpicks I noticed
@jtojnar I am not sure whether this makes sense to replace a |
A beta package increases the maintenance costs, especially keeping the two expressions in sync. Is there any reason why someone would need the old version (e.g. removed functionality)? In practice, we often see that while a release was not yet labelled stable, it is actually more stable than the most recent stable build, thanks to newly added bug fixes. For that reason, many packages in nixpkgs often use “unstable” releases or even VCS snapshots. But really, it needs to be judged on case by case basis. If the beta introduces more bugs than it fixes then parallel expression would be justified. In that case both expressions should share a directory and perhaps inherit from single common expression. |
@jtojnar well okay, I will make a new pr that upgrades the stable to the beta 😉 |
Motivation for this change
Only the stable version of vokoscreen is available, but is missing multiple features that I needed.
I already build and installed it locally and used it multiple times successfully :-)
I guess it could be bundled with the stable version, but this may be more reasonable when the beta and stable version will be maintained continuously.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)