Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pg_partman: init at 4.1.0 #61503

Merged
merged 1 commit into from May 14, 2019
Merged

pg_partman: init at 4.1.0 #61503

merged 1 commit into from May 14, 2019

Conversation

ggPeti
Copy link
Member

@ggPeti ggPeti commented May 14, 2019

Motivation for this change

To add pg_partman, a partition manager extension for Postgres.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggPeti
Copy link
Member Author

ggPeti commented May 14, 2019

Hi @thoughtpolice, I wanted to ask you for a review, but github overzealously did that (in my name, without my consent, nonetheless.) Still, please when you have the time, take a look, I've already tried it with postgresql 11 and it works like a charm.

Here's a short gif showing pg_partman built via this nix expression in a cluster where partitioning and retention was synced successfully from the master to the slaves:

rdspg

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build postgresqlPackages.pg_partman

@thoughtpolice thoughtpolice merged commit fd32d60 into NixOS:master May 14, 2019
@ggPeti ggPeti mentioned this pull request May 15, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggPeti @thoughtpolice