Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of use of "damer" as filler text #16820

Merged
merged 1 commit into from May 14, 2019

Conversation

gsnedders
Copy link
Member

We wouldn't accept "women" as filler text in English, and we shouldn't accept it just because it's in Norwegian.

Need to check results on wpt.fyi once this has run through TC/Azure to make sure we haven't regressed anything due to different word lengths.

We wouldn't accept "women" as filler text in English, and we
shouldn't accept it just because it's in Norwegian.
@gsnedders gsnedders merged commit 98ad54c into web-platform-tests:master May 14, 2019
@gsnedders gsnedders deleted the rm-sexism branch May 14, 2019 18:21
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
We wouldn't accept "women" as filler text in English, and we
shouldn't accept it just because it's in Norwegian.
@foolip
Copy link
Member

foolip commented Oct 23, 2020

I noticed we have one remaining case of this, the singular form "dam" in flexbox_justifycontent-center-overflow.html. Noticed because it fails everywhere and we should probably delete the test.

foolip added a commit that referenced this pull request Oct 23, 2020
…tions

The offsets -2.85em and 4.95em in the ref perhaps (at a guess) initially
matched precisely the Presto behavior, but now look like magic
constants, and slighly off in all implementations:
https://wpt.fyi/results/css/css-flexbox/flexbox_justifycontent-center-overflow.html?run_id=711240001&run_id=697770002&run_id=737900001&run_id=715540002&run_id=705490001

Control the width of the boxes more explicitly, so that the ref can be
written in a more straightforward way.

Also replaces "dam" (lady in Norwegian) with "x" to make the text much
shorter than the span widths, and matching an earlier rewrite:
#16820
foolip added a commit that referenced this pull request Oct 23, 2020
…tions

The offsets -2.85em and 4.95em in the ref perhaps (at a guess) initially
matched precisely the Presto behavior, but now look like magic
constants, and is slightly off in all implementations:
https://wpt.fyi/results/css/css-flexbox/flexbox_justifycontent-center-overflow.html?run_id=711240001&run_id=697770002&run_id=737900001&run_id=715540002&run_id=705490001

Control the width of the boxes more explicitly, so that the ref can be
written in a more straightforward way.

Also replaces "dam" (lady in Norwegian) with "x" to make the text much
shorter than the span widths, and matching an earlier rewrite:
#16820
tabatkins pushed a commit that referenced this pull request Oct 23, 2020
…tions (#26256)

The offsets -2.85em and 4.95em in the ref perhaps (at a guess) initially
matched precisely the Presto behavior, but now look like magic
constants, and is slightly off in all implementations:
https://wpt.fyi/results/css/css-flexbox/flexbox_justifycontent-center-overflow.html?run_id=711240001&run_id=697770002&run_id=737900001&run_id=715540002&run_id=705490001

Control the width of the boxes more explicitly, so that the ref can be
written in a more straightforward way.

Also replaces "dam" (lady in Norwegian) with "x" to make the text much
shorter than the span widths, and matching an earlier rewrite:
#16820
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 27, 2020
…flow.html to match implementations, a=testonly

Automatic update from web-platform-tests
Tweak flexbox_justifycontent-center-overflow.html to match implementations (#26256)

The offsets -2.85em and 4.95em in the ref perhaps (at a guess) initially
matched precisely the Presto behavior, but now look like magic
constants, and is slightly off in all implementations:
https://wpt.fyi/results/css/css-flexbox/flexbox_justifycontent-center-overflow.html?run_id=711240001&run_id=697770002&run_id=737900001&run_id=715540002&run_id=705490001

Control the width of the boxes more explicitly, so that the ref can be
written in a more straightforward way.

Also replaces "dam" (lady in Norwegian) with "x" to make the text much
shorter than the span widths, and matching an earlier rewrite:
web-platform-tests/wpt#16820
--

wpt-commits: a10802c3fb44605290b78773eb0080c75be8538c
wpt-pr: 26256
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this pull request Oct 27, 2020
…flow.html to match implementations, a=testonly

Automatic update from web-platform-tests
Tweak flexbox_justifycontent-center-overflow.html to match implementations (#26256)

The offsets -2.85em and 4.95em in the ref perhaps (at a guess) initially
matched precisely the Presto behavior, but now look like magic
constants, and is slightly off in all implementations:
https://wpt.fyi/results/css/css-flexbox/flexbox_justifycontent-center-overflow.html?run_id=711240001&run_id=697770002&run_id=737900001&run_id=715540002&run_id=705490001

Control the width of the boxes more explicitly, so that the ref can be
written in a more straightforward way.

Also replaces "dam" (lady in Norwegian) with "x" to make the text much
shorter than the span widths, and matching an earlier rewrite:
web-platform-tests/wpt#16820
--

wpt-commits: a10802c3fb44605290b78773eb0080c75be8538c
wpt-pr: 26256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants