better use nix run nixpkgs.nix-review. As for the tox testing, nixpkgs' hypothesis seems to remove the tox.ini . IIRC, you can look into the tox.ini and run the test directly in the checkPhase.

@teto thanks! Tests aren't all passing so made an issue here: python-jsonschema/jsonschema#562

Until an upstream fix, you could run only specific tests with -k https://docs.python.org/3.7/library/unittest.html#command-line-interface, there are some examples in nixpkgs

@teto thx! incorporated all suggestions.

All tests now passing for jsonschema

Unfortunately, a number of python packages hardcode jsonshema~=2.6. This can be fixed by adding sed -i "s/jsonschema~=2.6/jsonschema/" requirements/base.txt to postPatch. Should I do all of this in this pull request or make a new one for jsonschema?

Unfortunately, a number of python packages hardcode

How many ? If many we could bump jsonschema while keeping the version of 2.6 at the same time. I am not fond of patching the requirement since it may induce some other problems.

@teto ~17 packages rely on jsonschema, although I'm not sure how many specify a version. I know that aws-sam-translator and cfn-lint rely on 2.6, but haven't checked any others. I tried having two versions, but get the following error when trying to build:

Found duplicated packages in closure for dependency 'jsonschema': 
  jsonschema 3.0.1 (/nix/store/di3bkdy954ngkpwnnxi2cqwdwvqh76rj-python3.7-jsonschema-3.0.1/lib/python3.7/site-packages)
  jsonschema 2.6.0 (/nix/store/5z3pax2qlzqyy4xbx0wn0yc3gdv1kpil-python3.7-jsonschema-2.6.0/lib/python3.7/site-packages)

Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.

Ok not sure what to advise then, @FRidh should know better.

I was able to get work locally by using buildPythonApplication in nbdime and creating this overlay. Could do something similar for this pull request? That way can have two versions of jsonschema as @teto suggested.

(self: super: {
  nbdimeOverrides = python-self: python-super: {
    jsonschema = python-super.callPackage /Computer/packages/jsonschema.nix { };
      };
    pythonNbdime = super.python37.override {packageOverrides = self.nbdimeOverrides;};
  nbdime = super.callPackage /Computer/packages/nbdime.nix { python3Packages = self.pythonNbdime.pkgs; };
  })

@teto turns out the poetry pkg had to deal with jsonschema issue too. They resolved by making local nix derivation. I callPackage on this unlisted derivation. Let me know what you think..?

@GrahamcOfBorg build python37Packages.nbdime python38Packages.nbdime