Don't use assert_own_property in CSS tests. #16892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The cc's were supposed to be @lilles @ewilligers |
|
Per spec they're defined to be WebIDL attributes, so they should behave the same as |
gsnedders
approved these changes
May 16, 2019
They are in fact not supposed to be own properties. This caused all CSS tests to fail on Firefox for no good reason. See https://bugs.chromium.org/p/chromium/issues/detail?id=700338 for the bug that this tests are relying on.
emilio
force-pushed
the
style-own-property
branch
from
5f5bb93
to
553c93b
Compare
|
Sure, done. Will wait for CI just to sanity-check, but feel free to merge whenever if you get here before me :) |
|
We should probably add a check for the inverse, that they're not own properties? Otherwise this passes in Chrome while they're not compliant. |
|
Yeah I intentionally didn't do it since this is used in a lot of parsing and serialization tests that are important for interop. Testing it once per property is not useful, I suspect there's a test that chrome fails already because of that bug, but I'll file one otherwise. |
BorisChiou
added a commit
to BorisChiou/wpt
that referenced
this pull request
Jul 10, 2019
These `assert_own_property` tests cause these CSS tests to fail on Firefox only. I think these properties are not supposted to be own properties, and use a similar way as web-platform-tests#16892, to test the existence of these properties.
BorisChiou
added a commit
to BorisChiou/wpt
that referenced
this pull request
Jul 10, 2019
These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests#16892, to test the existence of these properties.
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
They are in fact not supposed to be own properties. This caused all CSS tests to fail on Firefox for no good reason. See https://bugs.chromium.org/p/chromium/issues/detail?id=700338 for the bug that this tests are relying on.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
…property on testing style properties., a=testonly Automatic update from web-platform-tests [css-transforms] Avoid using assert_own_property on style property. (#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests/wpt#16892, to test the existence of these properties. -- wpt-commits: 47543ee66eb535b6910292f199f3b789bec263f0 wpt-pr: 17778
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
…property on testing style properties., a=testonly Automatic update from web-platform-tests [css-transforms] Avoid using assert_own_property on style property. (#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests/wpt#16892, to test the existence of these properties. -- wpt-commits: 47543ee66eb535b6910292f199f3b789bec263f0 wpt-pr: 17778
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
…eb-platform-tests#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests#16892, to test the existence of these properties.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…property on testing style properties., a=testonly Automatic update from web-platform-tests [css-transforms] Avoid using assert_own_property on style property. (#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests/wpt#16892, to test the existence of these properties. -- wpt-commits: 47543ee66eb535b6910292f199f3b789bec263f0 wpt-pr: 17778 UltraBlame original commit: 3f420b25532cbc1cc2bb3b2b51430ec9c83b205b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…property on testing style properties., a=testonly Automatic update from web-platform-tests [css-transforms] Avoid using assert_own_property on style property. (#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests/wpt#16892, to test the existence of these properties. -- wpt-commits: 47543ee66eb535b6910292f199f3b789bec263f0 wpt-pr: 17778 UltraBlame original commit: 3f420b25532cbc1cc2bb3b2b51430ec9c83b205b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…property on testing style properties., a=testonly Automatic update from web-platform-tests [css-transforms] Avoid using assert_own_property on style property. (#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests/wpt#16892, to test the existence of these properties. -- wpt-commits: 47543ee66eb535b6910292f199f3b789bec263f0 wpt-pr: 17778 UltraBlame original commit: 3f420b25532cbc1cc2bb3b2b51430ec9c83b205b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are in fact not supposed to be own properties.
This caused all CSS tests to fail on Firefox for no good reason.
See https://bugs.chromium.org/p/chromium/issues/detail?id=700338 for the bug
that this tests are relying on.
This fixes e8b0b32. CC @lilles @ewilligers