FlakeCommand improvements #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSVdB
suggested changes
May 17, 2019
edolstra
force-pushed
the
improve-flake-command
branch
from
5add380
to
b6bf153
Compare
It now handles commonality like calling getFlake() and resolving relative local flake refs. Fixes #2822.
Also, rename --dont-save-lock-file to --no-save-lock-file and change noRegistries to useRegistries.
edolstra
force-pushed
the
improve-flake-command
branch
from
b6bf153
to
3e8ef9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now handles commonality like calling
getFlake(), resolving relative local flake refs, and creating/updating a lockfile.Also fixes #2822. All
nix flakesubcommands now work on relative directories and use.if no argument is given.