Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: add test for tinydns #61604

Merged
merged 1 commit into from May 16, 2019
Merged

Conversation

basvandijk
Copy link
Member

Motivation for this change

I used the tinydns service today and discovered there was no associated NixOS test. That always makes me a bit uneasy so I added this little test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg test tinydns

@basvandijk
Copy link
Member Author

@GrahamcOfBorg test tinydns.x86_64-linux

@basvandijk
Copy link
Member Author

@GrahamcOfBorg test tinydns

@basvandijk basvandijk merged commit 240ae5e into NixOS:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant