Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytricia: init at version 2019-01-16 #61494

Merged
merged 1 commit into from May 19, 2019
Merged

pytricia: init at version 2019-01-16 #61494

merged 1 commit into from May 19, 2019

Conversation

mkgvt
Copy link
Contributor

@mkgvt mkgvt commented May 14, 2019

Motivation for this change

Adding new package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented May 17, 2019

looks good, tested locally on NixOS and darwin; but just in case
@GrahamcOfBorg build pythonPackages.pytricia python3Packages.pytricia

@marsam marsam merged commit 6d7d657 into NixOS:master May 19, 2019
@marsam
Copy link
Contributor

marsam commented May 19, 2019

I added the unstable- prefix to version to conform the guidelines. I hope you don't mind
Thanks @mkgvt!

@mkgvt mkgvt deleted the pytricia branch May 20, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants