Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adom: Replace adom-noteye 1.2.0 with vanilla adom 3.3.3 #61491

Closed
wants to merge 2 commits into from
Closed

adom: Replace adom-noteye 1.2.0 with vanilla adom 3.3.3 #61491

wants to merge 2 commits into from

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented May 14, 2019 •
edited

Motivation for this change

The old adom-noteye download site was shut down sometime last year, and I couldn't find a replacement.

This PR entirely replaces the adom derivation with one wrapping vanilla adom, from the official site. In case adom-noteye is still wanted (and can be found), I suggest it should be a separate derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Baughn and others added 2 commits May 14, 2019 14:36
@Baughn
adom: Replace adom-noteye 1.2.0 with vanilla adom 3.3.3
f7ac61f 
The old adom-noteye download site was shut down sometime last year, and I couldn't find a replacement.

This PR entirely replaces the adom derivation with one wrapping vanilla adom, from the official site. In case adom-noteye is still wanted (and can be found), I suggest it should be a separate derivation.
@Baughn
Update default.nix
cd1edd3
@Baughn
Copy link
Contributor Author

Baughn commented May 14, 2019

The commits should be squashed, but I can't find a way to do that from within the GitHub UI. (Except by hitting 'squash and merge'.)

If desired, I can fix that up locally. I created this PR by copying and pasting my own adom.nix file.

@Baughn
Copy link
Contributor Author

Baughn commented May 14, 2019

Actually, belay this. Noteye appears to have been integrated with ADOM since last I played it.

I'll reopen with a more complete derivation.

@Baughn Baughn closed this May 14, 2019
@Baughn Baughn deleted the patch-5 branch May 14, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Baughn