[Gecko Bug 1545239] Make each test cases independent in resize-observer/observe.html. #16877
Conversation
I think it's better to make sure each test is independent from others, so we create elements inside each test function. (Only change observe.html because I touch only this file in this bug.) Differential Revision: https://phabricator.services.mozilla.com/D29889 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545239 gecko-commit: 01338a1e26b7d838ddd591fca9a7495e338c6c96 gecko-integration-branch: central gecko-reviewers: dholbert
1. Add new tests with an extra argument of "content-box"/"border-box" in observe(), and test contectBoxSize and borderBoxSize. 2. Add a new test for changing the writing mode. Changing writing mode makes the element change the orientation, but the logical box size is still the same, so we shouldn't fire the event. Differential Revision: https://phabricator.services.mozilla.com/D28739 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545239 gecko-commit: b34ea6abce97b002de66d2d0376b84e347f3151a gecko-integration-branch: central gecko-reviewers: dholbert
Differential Revision: https://phabricator.services.mozilla.com/D30129 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545239 gecko-commit: a0c91ab4d3477cdb041c00dee13354cafafb83fd gecko-integration-branch: central gecko-reviewers: dholbert
|
CC @BorisChiou TEST-UNEXPECTED-FAIL | /resize-observer/idlharness.window.html | ResizeObservation interface: existence and properties of interface object - assert_own_property: self does not have own property "ResizeObservation" expected property "ResizeObservation" missing https://taskcluster-artifacts.net/ZXxdYQZVT3W96ftXdDMiaQ/0/public/logs/live_backing.log |
|
It looks like that failure is really a bug in the test, and is tracked in w3c/csswg-drafts#3839 |
|
So the firefox-nightly-stability "failure" here is actually Firefox getting the correct result, and is a test-issue that predates this change (per w3c/csswg-drafts#3839 ). So, we should disregard that & should consider this pull request as force-merge-worthy. CC @gsnedders would you mind helping with that? |
|
I can help! |
|
Thanks @jgraham! And sorry to frequently bug you for this sort of thing, @gsnedders - I should bias more towards @jgraham. :D |
|
Also: sorry, my diagnosis in #16877 (comment) was actually wrong (but all is well). The real reason the firefox-nightly-stability task failed was because of a stability issue, not a test-failure issue. Specifically, the Anyway, that's not a concern here because:
|
I think it's better to make sure each test is independent from others, so we
create elements inside each test function. (Only change observe.html
because I touch only this file in this bug.)
Differential Revision: https://phabricator.services.mozilla.com/D29889
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545239
gecko-commit: 01338a1e26b7d838ddd591fca9a7495e338c6c96
gecko-integration-branch: central
gecko-reviewers: dholbert