[Gecko Bug 1545823] Implement non-standard CSSStyleSheet.rules, CSSStyleSheet.addRule and CSSStyleSheet.removeRule. #16876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CSSStyleSheet.removeRule. It's not worth dying on this hill. Both Blink and WebKit pass the tests. (Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules are not the same JS object, WebKit returns a new rule list. I'll file) Spec PR in w3c/csswg-drafts#3900. Differential Revision: https://phabricator.services.mozilla.com/D30348 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545823 gecko-commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693 gecko-integration-branch: central gecko-reviewers: bzbarsky
wpt-pr-bot
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not worth dying on this hill. Both Blink and WebKit pass the tests.
(Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules
are not the same JS object, WebKit returns a new rule list. I'll file)
Spec PR in w3c/csswg-drafts#3900.
Differential Revision: https://phabricator.services.mozilla.com/D30348
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545823
gecko-commit: a93ed2a80220b9ba15fb9b59ea79b5f1ee8f7693
gecko-integration-branch: central
gecko-reviewers: bzbarsky