[Gecko Bug 1527392] Do not clamp computed width and height by min-/max- values. #16874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec says that when there's no box or the property doesn't apply, the computed value should be returned. That's not what we're doing right now, we're clamping by min-/max- values, which is wrong. This patch makes us match other engines and the spec, and it's an attempt to get interop on resolved values in: w3c/csswg-drafts#3678 WebKit fails the WPT test, but due to a different reason: https://bugs.webkit.org/show_bug.cgi?id=197814 Differential Revision: https://phabricator.services.mozilla.com/D30780 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1527392 gecko-commit: d51f3432e142ef24333b125087f5fccc2fbc366a gecko-integration-branch: central gecko-reviewers: mats
wpt-pr-bot
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says that when there's no box or the property doesn't apply, the
computed value should be returned.
That's not what we're doing right now, we're clamping by min-/max- values, which
is wrong.
This patch makes us match other engines and the spec, and it's an attempt to get
interop on resolved values in:
w3c/csswg-drafts#3678
WebKit fails the WPT test, but due to a different reason:
https://bugs.webkit.org/show_bug.cgi?id=197814
Differential Revision: https://phabricator.services.mozilla.com/D30780
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1527392
gecko-commit: d51f3432e142ef24333b125087f5fccc2fbc366a
gecko-integration-branch: central
gecko-reviewers: mats