[Gecko Bug 1505471] Map intersection observer rects to the right viewport. #16875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targetFrame is modified during the intersection computation loop, so it's not the viewport you want if there are scrollframes around. The test is the same as iframe-no-root.html but with a wrapping scroller which triggers this bug. This code is quite subtle, so will refactor and clean it up in a followup. Differential Revision: https://phabricator.services.mozilla.com/D31147 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1505471 gecko-commit: 5f88dc67d75ba1e08dad4c4e9b39a8df593b2be6 gecko-integration-branch: central gecko-reviewers: mstange
wpt-pr-bot
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetFrame is modified during the intersection computation loop, so it's not
the viewport you want if there are scrollframes around.
The test is the same as iframe-no-root.html but with a wrapping scroller which
triggers this bug.
This code is quite subtle, so will refactor and clean it up in a followup.
Differential Revision: https://phabricator.services.mozilla.com/D31147
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1505471
gecko-commit: 5f88dc67d75ba1e08dad4c4e9b39a8df593b2be6
gecko-integration-branch: central
gecko-reviewers: mstange