Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoapods: 1.6.1 -> 1.6.2 #61547

Merged
merged 2 commits into from May 17, 2019
Merged

cocoapods: 1.6.1 -> 1.6.2 #61547

merged 2 commits into from May 17, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented May 15, 2019

Also update cocoapods-beta to 1.7.0.rc.2

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.6.2
https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.0.rc.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'm not sure if it's appropriate to update two packages in the same PR (separate commits), but they're different versions of the same underlying package and they were released together.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 17, 2019

@GrahamcOfBorg build cocoapods cocoapods-beta

@c0bw3b c0bw3b merged commit c0cbfdc into NixOS:master May 17, 2019
@lilyball lilyball deleted the cocoapods branch May 18, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants