Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_element_tag_name tests should expect uppercase tag name as result #16830

Open
dcrousso opened this issue May 14, 2019 · 1 comment
Open

get_element_tag_name tests should expect uppercase tag name as result #16830

dcrousso opened this issue May 14, 2019 · 1 comment
Labels
webdriver

Comments

@dcrousso
Copy link
Contributor

In chapter 12. Elements, section 12.3 State, subsection 12.3.6 Get Element Tag Name:

  1. Let qualified name be the result of getting element’s tagName content attribute.

The definition for tagName in the HTML spec is:

The tagName attribute’s getter must return the context object’s HTML-uppercased qualified name.

where HTML-uppercased qualified name is:

... qualifiedName in ASCII uppercase.

As such, all of the get_element_tag_name tests should be using the upper-cased version of the tag name in every assertion.

As an example:

- assert_success(response, "input")
+ assert_success(response, "INPUT")
@gsnedders
Copy link
Member

test_get_element_tag_name in webdriver/tests/get_element_tag_name/get.py seems to pass in Chrome/Firefox, and for whatever reason didn't successfully run in Safari. If we already have interop here, it may simply be a case that we should change the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
webdriver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsnedders @dcrousso