Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of WorkletAnimationEffect #16829

Merged
merged 1 commit into from May 20, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 14, 2019

Includes read only .getTiming() function for use on animation worklet
threads. Renamed old proxy files to match new structure.

WorkletGroupEffectProxy -> WorkletGroupEffect
EffectProxy             -> WorkletAnimationEffect

Design Doc: https://docs.google.com/document/d/1AoLLgrUzp11ZPlEztQ73M5PxIULVZrj6U2OZSMXeFOI/edit#heading=h.8kd6haf9q9ij

Bug: 915344
Change-Id: Ib43d7225d47d145a8d1364472373a514407d5d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568315
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#661400}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1568315 branch 7 times, most recently from bd1e48e to 2c1318c Compare May 17, 2019 21:48
Includes read only .getTiming() function for use on animation worklet
threads. Renamed old proxy files to match new structure.

    WorkletGroupEffectProxy -> WorkletGroupEffect
    EffectProxy             -> WorkletAnimationEffect

Design Doc: https://docs.google.com/document/d/1AoLLgrUzp11ZPlEztQ73M5PxIULVZrj6U2OZSMXeFOI/edit#heading=h.8kd6haf9q9ij

Bug: 915344
Change-Id: Ib43d7225d47d145a8d1364472373a514407d5d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568315
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#661400}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants