Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration-hackage2nix.yaml: lattices is not broken #61536

Merged
merged 1 commit into from May 22, 2019

Conversation

endgame
Copy link
Contributor

@endgame endgame commented May 15, 2019

Motivation for this change

Some guy at the airport asked me why lattices was broken. The following command built successfully in my checkout of master.

nix-build -E '(import ./. { config.allowBroken = true; }).haskellPackages.lattices'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame endgame requested a review from basvandijk as a code owner May 15, 2019 09:46
@endgame endgame changed the base branch from master to haskell-updates May 22, 2019 20:56
@infinisil infinisil merged commit b3ec771 into NixOS:haskell-updates May 22, 2019
@endgame endgame deleted the lattices-is-not-broken branch May 22, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants