New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACL field to rooms #3929
Add ACL field to rooms #3929
Conversation
pferreir
commented
May 15, 2019
•
edited
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look closer into some of the functions yet - just a bunch of things I noticed when having a quick look over the code.
indico/web/client/js/react/components/principals/PrincipalPermissions.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/PopoverDropdownMenu.module.scss
Outdated
Show resolved
Hide resolved
cc59b8f
to
f4b1c0b
Compare
indico/web/client/js/react/components/principals/PermissionTree.jsx
Outdated
Show resolved
Hide resolved
indico/web/client/js/react/components/principals/PermissionTree.jsx
Outdated
Show resolved
Hide resolved
71f3186
to
84b42d4
Compare
What about removing the entry when removing the last permission? The unclickable (x) when there's just a single permission is a bit weird. Or it could be greyed-out (and excluded from the |
Something in the value isn't 100% consistent. When I add a new permission and remove it again, the save button doesn't get disabled again, so the old/new value aren't equal. Edit: Looks like it;s just missing |
Already suggested by @mic4ael 😉 , but thanks! |
Solved! |
... instead of hackish SemanticUI Menu code.
Since we shouldn't be using Room Booking stuff in here