Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 1d37727453a3
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 2b13c29c3ce5
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 25, 2019

  1. nixos/tinc: remove ordering dependency on network.target 

    This allows configuring IP addresses on a tinc interface using
networking.interfaces."tinc.${n}".ipv[46].addresses.

Previously, this would fail with timeouts, because of the dependency
chain
tinc.${netname}.service
--after--> network.target
--after--> network-addresses-tinc.${n}.service (and network-link-…)
--after--> sys-subsystem-net-devices-tinc.${n}.device

But the network interface doesn't exist until tinc creates it! So
systemd waits in vain for the interface to appear, and by then the
network-addresses-* and network-link-* units have failed. This leads
to the network link not being brought up and the network addresses not
being assigned, which in turn stops tinc from actually working.
    @lheckemann
    lheckemann committed Apr 25, 2019
    Copy the full SHA
    d4cd164 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Merge pull request #60231 from mayflower/tinc-allow-networking-interf… 

    …aces

nixos/tinc: remove ordering dependency on network.target
    @lheckemann
    lheckemann committed May 14, 2019
    Copy the full SHA
    2b13c29 View commit details
    Browse the repository at this point in the history