Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] pythonPackages.rednose: disable test suite #61542

Merged
merged 1 commit into from May 16, 2019
Merged

[19.03] pythonPackages.rednose: disable test suite #61542

merged 1 commit into from May 16, 2019

Conversation

nixbitcoin
Copy link
Contributor

@nixbitcoin nixbitcoin commented May 15, 2019 •
edited

python test suite stalls when building rednose. The test suite had previously been disabled for Darwin because of a similar error. This commit disables it for all systems using python 2.7.

(cherry picked from commit 6600115)

Reason: Building nixops without substitutes fails if the test suite stalls for rednose. This should be included in stable to prevent people building from release 19.03 from having stalled installations.

Motivation for this change

Backport of #60805
/cc @FRidh @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixbitcoin nixbitcoin requested a review from FRidh as a code owner May 15, 2019 14:01
@nixbitcoin nixbitcoin changed the title rednose: disable test suite [19.03] rednose: disable test suite May 15, 2019
@nixbitcoin nixbitcoin mentioned this pull request May 15, 2019
Closed
10 tasks
worldofpeace
worldofpeace approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, noticed you corrected the commit msg for 19.03 thanks 👍

@nixbitcoin @worldofpeace
pythonPackages.rednose: disable test suite
921d40d 
python test suite stalls when building rednose. The test suite had previously been disabled for Darwin because of a similar error. This commit disables it for all systems using python 2.7.

(cherry picked from commit 6600115)

Reason: Building nixops without substitutes fails if the test suite stalls for rednose. This should be included in stable to prevent people building from release 19.03 from having stalled installations.
@worldofpeace worldofpeace changed the title [19.03] rednose: disable test suite [19.03] pythonPackages.rednose: disable test suite May 16, 2019
@worldofpeace worldofpeace merged commit c21f08b into NixOS:release-19.03 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nixbitcoin @worldofpeace