Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libjpeg_turbo: Fix tests with musl. #61579

Closed
wants to merge 1 commit into from
Closed

libjpeg_turbo: Fix tests with musl. #61579

wants to merge 1 commit into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented May 16, 2019

Motivation for this change

The path given in LD_LIBRARY_PATH was wrong; the .so files were in a build subdir of what was set.

For glibc that doesn't seem to matter at all, but with pkgsMusl the tests complained about the lack of .so file and many tests failed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
libjpeg_turbo: Fix tests with musl.
b2f53bf 
The path given in LD_LIBRARY_PATH was wrong; the .so files were in
a `build` subdir of what was set.

For glibc that doesn't seem to matter at all, but with `pkgsMusl`
the tests complained about the lack of `.so` file and many tests failed.
@nh2 nh2 requested review from matthewbauer and romildo May 16, 2019 01:55
@ofborg ofborg bot requested a review from vcunat May 16, 2019 02:31
@vcunat vcunat self-assigned this May 26, 2019
@vcunat vcunat changed the base branch from master to staging May 26, 2019 07:50
@vcunat
Copy link
Member

vcunat commented May 26, 2019

Superseded by #58374. I'll close after verifying that pkgsMusl.libjpeg builds fine, but it seems very likely.

@vcunat vcunat closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@romildo romildo Awaiting requested review from romildo

@vcunat vcunat Awaiting requested review from vcunat

Assignees

@vcunat vcunat

Labels
2.status: merge conflict 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @vcunat