buildRustPackage: fix cargo flag for release/debug build #61521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior did not actually allow for "debug" build as it would try to pass --debug to cargo, which is not a valid flag.
|
Related: #56540 |
|
Ping? |
Mic92
reviewed
Jul 26, 2019
pkgs/build-support/rust/default.nix
Outdated
| @@ -103,7 +105,7 @@ in stdenv.mkDerivation (args // { | |||
| "CC_${stdenv.hostPlatform.config}"="${ccForHost}" \ | |||
| "CXX_${stdenv.hostPlatform.config}"="${cxxForHost}" \ | |||
| cargo build \ | |||
| --${buildType} \ | |||
| ${releaseFlag} \ | |||
There was a problem hiding this comment.
Suggested change
| ${releaseFlag} \ | |
| ${optionalString (buildType == "release") "--release"} \ |
adelbertc
force-pushed
the
fix-rust-release-flag
branch
from
6381de9
to
8a734e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previous behavior did not actually allow for "debug" build as it would
try to pass --debug to cargo, which is not a valid flag.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)