Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocked] vapoursynth-editor: init at R19 #61522

Closed

Conversation

tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented May 14, 2019

depends on #58859, don't merge before (I can't mark a PR as draft after it's made)

Motivation for this change

More vapoursynth changes. This is the most popular (only?) script editor for vapoursynth.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

LD_LIBRARY_PATH is needed since the library is loaded at runtime.

previously, vapoursynth was not a python module in how most python
libraries are in nixpkgs. it would only work as part of a library or
other program, and not with its included `vspipe` program.

this fixes it by adding a new output for its python module and uses
toPythonModule to allow it to work standalone, and without conflicting
with other python packages in a nix-shell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant