Add tentative WPT for CookiesWithoutSameSiteMustBeSecure #16831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1612052
branch
2 times, most recently
from
9261d54
to
3e624e2
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1612052
branch
2 times, most recently
from
a62145e
to
b22be14
Compare
This change adds a virtual test suite which enables CookiesWithoutSameSiteMustBeSecure and adds a new tentative test to test that (with the feature enabled) cookies with SameSite=None must have the Secure attribute, and will be rejected otherwise. Bug: 961439 Change-Id: Icd99b6fc9ef38f72b648fb81f3fd0aa241e75a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612052 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#662818}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1612052
branch
from
b22be14
to
1844ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a virtual test suite which enables
CookiesWithoutSameSiteMustBeSecure and adds a new tentative test to
test that (with the feature enabled) cookies with SameSite=None must
have the Secure attribute, and will be rejected otherwise.
Bug: 961439
Change-Id: Icd99b6fc9ef38f72b648fb81f3fd0aa241e75a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612052
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662818}