Hide Sec-Fetch-... headers from service worker fetch event.
#16833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1611314
branch
from
90c5053
to
68a25be
Compare
This CL excludes Sec-Fetch-... request headers from the Request object passes to the service worker's `fetch` event. This CL also adds WPT tests that verify that these request headers will be re-added when the service worker forwards the request back into the network (via implicit fallback, or via an explicit responseWith+fetch). Bug: 949997 Change-Id: I04422a1630f62b497961ca1789007f2402148e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611314 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659937}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1611314
branch
from
68a25be
to
188318a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL excludes Sec-Fetch-... request headers from the Request object
passes to the service worker's
fetchevent. This CL also adds WPTtests that verify that these request headers will be re-added when the
service worker forwards the request back into the network (via implicit
fallback, or via an explicit responseWith+fetch).
Bug: 949997
Change-Id: I04422a1630f62b497961ca1789007f2402148e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611314
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659937}