Added a 'none' to XREye enum #16891
Merged
Added a 'none' to XREye enum #16891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1615541
branch
2 times, most recently
from
68774f2
to
03c0258
Compare
Adds a new 'none' value to the XREye enum to indicate times when a view is not instrinsically associated with any specific eye. Ensured that views for inline sessions report an eye of 'none'. Bug: 963158 Change-Id: I6c091240d1c68cf658bb5f496308c08bde35e541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615541 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#660535}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1615541
branch
from
03c0258
to
6c82aff
Compare
|
Mojo flakiness is pre-existing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new 'none' value to the XREye enum to indicate times when a view
is not instrinsically associated with any specific eye. Ensured that
views for inline sessions report an eye of 'none'.
Bug: 963158
Change-Id: I6c091240d1c68cf658bb5f496308c08bde35e541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615541
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660535}