Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for querying supported input coupling modes #67

Closed
azonenberg opened this issue May 16, 2019 · 3 comments
Closed

Add API for querying supported input coupling modes #67

azonenberg opened this issue May 16, 2019 · 3 comments
Labels
api API improvements
Milestone
v0.1

Comments

@azonenberg
Copy link
Collaborator

If the user requests 50-ohm input on a scope that doesn't have it, most drivers will no-op and maybe print a message to the console.

Ideally, there should be a way for drivers to communicate that the (low end) scope has high-impedance inputs only, and disable/hide the 50 ohm option in the UI.
@azonenberg azonenberg added the api API improvements label May 16, 2019
@azonenberg
Copy link
Collaborator Author

Some scopes don't have ground coupling either. We should have a new API in the Oscilloscope class that returns a set so UIs can hide unsupported options.

@azonenberg azonenberg changed the title Figure out how to handle scopes without 50 ohm input better Add API for querying supported input coupling modes Feb 25, 2020
@azonenberg
Copy link
Collaborator Author

Proposed interface: virtual std::setOscilloscopeChannel::CouplingType GetAllowedChannelCoupling() =0;

@azonenberg
Copy link
Collaborator Author

Also related: Siglent scopes (at least SDS2000X+) support AC coupled 50 ohm inputs!

@azonenberg azonenberg added this to the v0.1 milestone Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API improvements
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@azonenberg