Add references to a couple more Flexbox tests #8804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
atanassov,
chenxix,
fantasai,
kojiishi,
mrego,
plinss and
tabatkins
Build PASSEDStarted: 2017-12-26 23:05:12 View more information about this build on: |
|
@gsnedders why is this a manual test, based on what I'm seeing it could be a testharness.js test? I asked the browser build question in #8670 - but looking quickly at Edge 16, FF, Chrome they all repro the same (I changed the background color to blue FYI to make this easier).
Getting a bit more specific with computed values on #test
|
|
@gregwhitworth Manual? Only previously. Turned into a reftest because it's easier to rewrite it without understanding much of it. |
|
c. six month ping for review |
gsnedders
force-pushed
the
flex-tests-manual
branch
from
66f887d
to
1e043f8
Compare
|
c. 1 year ping for review |
wpt-pr-bot
requested review from
rachelandrew
and removed request for
atanassov and
chenxix
cbiesinger
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8670.
http://test.csswg.org/harness/results/css-flexbox-1_dev/grouped/flex-direction-row-vertical/ shows that that test apparently fails in Edge, so this gives us automated coverage of that failure.
For the Opera test, see https://github.com/operasoftware/presto-testo/blob/master/css/flexbox/stf-fixpos.html