[LayoutNG] Fix the NGExclusionSpaceInternal vectors going out of sync. #16860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613560
branch
from
b8c49a1
to
151eeb3
Compare
NGExclusion::operator== didn't previous compare shape_data. This turned out to be a bad optimization. :) Without this we'd end up in a situation where we would have: - An exclusion vector containing an exclusion with shape data. - Derived geometry which wasn't tracking shape data. Bug: 963580 Change-Id: I21746f8fd081ff24658768ee6074122f2e913bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613560 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#661191}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613560
branch
from
151eeb3
to
8a85c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGExclusion::operator== didn't previous compare shape_data. This turned
out to be a bad optimization. :)
Without this we'd end up in a situation where we would have:
Bug: 963580
Change-Id: I21746f8fd081ff24658768ee6074122f2e913bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613560
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661191}