Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2019 05 15 patchwork #61530

Merged
merged 2 commits into from May 26, 2019
Merged

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented May 15, 2019

Motivation for this change

same as #59111 with different commit history

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@exarkun
Copy link
Contributor

exarkun commented May 17, 2019

This looks approximately correct to me. In fact, I just packaged patchwork as well and was about to submit a PR when I found this one. My packaging is almost exactly like this package. I also tried this out on my nixos and it seems to work.

So please consider this a +1 from me.

@livnev
Copy link
Contributor

livnev commented May 22, 2019

Tested, it works great for me! 👍

@octalsrc
Copy link
Contributor

I have also tested it, with no problems (NixOS).

@infinisil infinisil merged commit 6e46d0b into NixOS:master May 26, 2019
@matthiasbeyer
Copy link
Contributor

Awesome

This was referenced May 27, 2019
@tilpner
Copy link
Member

tilpner commented Jun 17, 2019

This is very similar to #53156, in which I requested not to use appimage-run. Unfortunately I didn't see this PR in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants