Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overscroll-behavior logical longhands #16890

Merged
merged 1 commit into from Jul 10, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 16, 2019

Flow relative longhands have been added to overscroll-behavior
specification [1]. This CL implements the relevant css parsing
and matching tests.

minor change: collapse all overscrollBehavior related case
statements in parser fast path.

intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/V86fOkIaEQA/JydSaafqBwAJ

[1] https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical

TESTS: wpt/css/css-overscroll-behavior/ovescroll-behavior-logical.html, wpt/css/css-overscroll-behavior/parsing/*

Bug: 833953
Change-Id: I5ceefa0afb1913472c0e134b2ec07405154abfae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614026
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676042}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WIP] Add support for logical longhands for overscroll-behavior Add support for overscroll-behavior logical longhands Jun 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614026 branch 2 times, most recently from 38e8c30 to ec1d0b2 Compare July 9, 2019 13:53
Flow relative longhands have been added to overscroll-behavior
specification [1]. This CL implements the relevant css parsing
and matching tests.

minor change: collapse all overscrollBehavior related case
statements in parser fast path.

intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/V86fOkIaEQA/JydSaafqBwAJ

[1] https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical

TESTS: wpt/css/css-overscroll-behavior/ovescroll-behavior-logical.html, wpt/css/css-overscroll-behavior/parsing/*

Bug: 833953
Change-Id: I5ceefa0afb1913472c0e134b2ec07405154abfae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614026
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676042}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants