adom: Rewrite derivation, add ascii-only variant #61543
Conversation
|
There's no documentation for adom. I wasn't really expecting any. In such a case, does that count as being 'up to date'? |
| luajit | ||
| ]; | ||
|
|
||
| unpackPhase = '' |
There was a problem hiding this comment.
You could probably set sourceRoot = "./adom"; instead of overriding the whole unpack phase.
There was a problem hiding this comment.
The default unpackPhase fails to unpack the files from indiedb.com, as they lack extensions. However, on trying this again I find that the URLs no longer work -- they're presumably temporary.
Not sure what to do about that. Ask the ADOM author, probably.
There was a problem hiding this comment.
Yeah those file share sites are hostile to scripted downloads. Are you sure the author permits redistribution? :) I don't see it listed in Debian or Ubuntu package sets, even though the author provides debs...
There was a problem hiding this comment.
Debian has a thing against non-free software. It might be in the non-free repo, haven't checked.
The 'downloads' page does say to contact him if there are any packaging issues for new distros, so I'll do that.
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
|
ping (triage) |
|
I was never able to get in touch with the author. I think we can consider this pull request dead -- anyway, ADOM is on Steam now. |
Motivation for this change
The mirror currently used for ADOM has died.
This PR points at the new one that's linked from adom.de. In addition I added a derivation for the (much smaller) ascii-only variant, updated the derivation to use autoPatchElf, and added a hypothetically-functional i686 version. I unfortunately cannot test that, as some of the dependencies fail when cross-compiling.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)