Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saleae-logic: 1.2.28 -> 1.2.18 #61586

Merged
merged 1 commit into from May 17, 2019
Merged

saleae-logic: 1.2.28 -> 1.2.18 #61586

merged 1 commit into from May 17, 2019

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented May 16, 2019

Yes, this is a downgrade. The .28 version is beta software, whereas .18
is the latest stable version. Ref. #53844

Motivation for this change

Have latest stable version, but not beta software.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Yes, this is a downgrade. The .28 version is beta software, whereas .18
is the latest stable version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant