Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.171 -> 32.0.0.192 [Critical security fix] #61540

Merged
merged 1 commit into from May 15, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented May 15, 2019

Motivation for this change
  • Critical security fix
  • Other bug fixes

https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html
https://helpx.adobe.com/security/products/flash-player/apsb19-26.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Assured whether relevant documentation is up to date

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played those videos with Firefox (x86_64) and Chromium (x86_64)


Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61540 1

3 package were build:
  • flashplayer
  • flashplayer-standalone
  • flashplayer-standalone-debugger

@c0bw3b c0bw3b merged commit 2f1f9a9 into NixOS:master May 15, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 15, 2019

@taku0 do you plan on opening a PR for the backport to 19.03?
Otherwise I'll do it later.

EDIT: --> #61550

@c0bw3b c0bw3b mentioned this pull request May 15, 2019
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants